Authored by LUOXC

refactor

@@ -17,7 +17,7 @@ public interface TradeBillsMapper { @@ -17,7 +17,7 @@ public interface TradeBillsMapper {
17 List<TradeBills> selectByConditionWithPage(@Param("billsTradeReq") TradeBillsReq req); 17 List<TradeBills> selectByConditionWithPage(@Param("billsTradeReq") TradeBillsReq req);
18 18
19 19
20 - List<TradeBillsTransferOutTradeNo> selectTransferOutTradeNoByOrderCodes(@Param("orderCodes") List<Long> orderCodes); 20 + List<TradeBillsTransferOutTradeNo> selectTransferOutTradeNoByIds(@Param("ids") List<Integer> ids);
21 21
22 List<TradeBills> selectByFailTradeBills(@Param("fromCreateTime") int fromCreateTime, @Param("fromTradeBillsId") int fromTradeBillsId, @Param("limit") int limit); 22 List<TradeBills> selectByFailTradeBills(@Param("fromCreateTime") int fromCreateTime, @Param("fromTradeBillsId") int fromTradeBillsId, @Param("limit") int limit);
23 23
@@ -2,8 +2,6 @@ package com.yoho.order.model; @@ -2,8 +2,6 @@ package com.yoho.order.model;
2 2
3 import lombok.Data; 3 import lombok.Data;
4 4
5 -import java.math.BigDecimal;  
6 -  
7 /** 5 /**
8 * 交易流水表 6 * 交易流水表
9 */ 7 */
@@ -14,6 +12,4 @@ public class TradeBillsTransferOutTradeNo { @@ -14,6 +12,4 @@ public class TradeBillsTransferOutTradeNo {
14 12
15 private String outTradeNo; 13 private String outTradeNo;
16 14
17 - private Long orderCode;  
18 -  
19 } 15 }
@@ -86,25 +86,19 @@ @@ -86,25 +86,19 @@
86 limit #{billsTradeReq.start},#{billsTradeReq.size} 86 limit #{billsTradeReq.start},#{billsTradeReq.size}
87 </select> 87 </select>
88 88
89 - <select id="selectTransferOutTradeNoByOrderCodes" resultType="com.yoho.order.model.TradeBillsTransferOutTradeNo"> 89 + <select id="selectTransferOutTradeNoByIds" resultType="com.yoho.order.model.TradeBillsTransferOutTradeNo">
90 SELECT tb.id, 90 SELECT tb.id,
91 CASE t.interface_type 91 CASE t.interface_type
92 WHEN 2 THEN concat(t.id, '_', IF(tb.deal_relate_id != 0,tb.deal_relate_id,tb.id)) 92 WHEN 2 THEN concat(t.id, '_', IF(tb.deal_relate_id != 0,tb.deal_relate_id,tb.id))
93 WHEN 3 THEN '钱包' 93 WHEN 3 THEN '钱包'
94 - END AS outTradeNo,  
95 - tb.order_code AS orderCode 94 + END AS outTradeNo
96 FROM ufo_order.trade_bills tb 95 FROM ufo_order.trade_bills tb
97 LEFT JOIN ufo_order.orders_pay_transfer t ON t.buyer_order_code = tb.order_code 96 LEFT JOIN ufo_order.orders_pay_transfer t ON t.buyer_order_code = tb.order_code
98 WHERE tb.income_outcome = 1 AND tb.deal_status != 1 97 WHERE tb.income_outcome = 1 AND tb.deal_status != 1
99 - <!-- 转账单 -->  
100 - AND (  
101 - tb.trade_type = 3 <!-- 补偿款 -->  
102 - OR (tb.user_type =2 AND tb.trade_type = 2) <!-- 卖家货款 -->  
103 - OR (tb.user_type =2 AND tb.trade_type = 4) <!-- 卖家返利 -->  
104 - )  
105 - AND tb.order_code IN  
106 - <foreach collection="orderCodes" item="orderCode" open="(" close=")" separator=",">  
107 - #{orderCode} 98 + <!-- 程序保障是转账单 id -->
  99 + AND tb.id IN
  100 + <foreach collection="ids" item="id" open="(" close=")" separator=",">
  101 + #{id}
108 </foreach> 102 </foreach>
109 </select> 103 </select>
110 104
@@ -256,14 +256,14 @@ public class TradeBillsServiceImpl implements ITradeBillsService { @@ -256,14 +256,14 @@ public class TradeBillsServiceImpl implements ITradeBillsService {
256 } 256 }
257 257
258 private Map<Integer, String> getTransferOutTradeNoMap(List<TradeBills> tradeBillsList) { 258 private Map<Integer, String> getTransferOutTradeNoMap(List<TradeBills> tradeBillsList) {
259 - List<Long> orderCodes = tradeBillsList.stream() 259 + List<Integer> ids = tradeBillsList.stream()
260 .filter(item -> MoneyTypeEnum.from(item).map(MoneyTypeEnum::isTransfer).orElse(Boolean.FALSE)) 260 .filter(item -> MoneyTypeEnum.from(item).map(MoneyTypeEnum::isTransfer).orElse(Boolean.FALSE))
261 - .map(TradeBills::getOrderCode) 261 + .map(TradeBills::getId)
262 .collect(Collectors.toList()); 262 .collect(Collectors.toList());
263 - if (CollectionUtils.isEmpty(orderCodes)) { 263 + if (CollectionUtils.isEmpty(ids)) {
264 return Maps.newHashMap(); 264 return Maps.newHashMap();
265 } 265 }
266 - return tradeBillsMapper.selectTransferOutTradeNoByOrderCodes(orderCodes) 266 + return tradeBillsMapper.selectTransferOutTradeNoByIds(ids)
267 .stream() 267 .stream()
268 .collect(Collectors.toMap(TradeBillsTransferOutTradeNo::getId, TradeBillsTransferOutTradeNo::getOutTradeNo)); 268 .collect(Collectors.toMap(TradeBillsTransferOutTradeNo::getId, TradeBillsTransferOutTradeNo::getOutTradeNo));
269 } 269 }