ios / yh_sdwebimage · Commits

More SDWebImageDownloader Cleanup

… background thread also the async calls are unnecessary.

It won't fix the underlying issue but I hope it will avoid it in most cases.
The various crash reports indicate the underlying download operation is being
freed before the async block in dataReceived is being executed.

This fix change tries to avoid every calling the async block.

Support a maximum disk cache size in -cleanDisk.

Fix completionBlock setter semantics

Using `SDDispatchQueueSetterSementics`, which might be `assign` for a block is a terrible idea.

…m disk in queryDiskCacheForKey

Remove double import for SDWebImageDecoder.h

Previously, -cleanDisk would only remove cache files that were older
than the configured expiration date.  This allowed the disk cache to
grow significantly if a large number of resources were cached over a
short period of time.

This change adds a second (optional) size-based cleaning pass that
removes files from the disk cache until its overall size falls below
half of the configured maximum size.  Older files are deleted first.

The size-based pass is disabled by default (maxCacheSize == 0).

-getSize now returns an `unsigned long long`.

This type now matches the type and width of the value returned by the
`fileSize` accessor of the `NSDictionary (NSFileAttributes)` category
(which is what is used when accumulating the total cache size).

New name for SDWebImageDownloaderQueueMode type, typo fixing, strong cycle fixing.

* develop:
  Potential strong cycle fixed.
  SDWebImageDownloaderQueueMode type renamed. Fixed typo. Added description for renamed type. Type renamed because "queue" notion is a FIFO only, but LIFO is a stack, and if we give the type a neutral name, we can avoid logical inconsistencies.
  Fixed typo.

…named type. Type renamed because "queue" notion is a FIFO only, but LIFO is a stack, and if we give the type a neutral name, we can avoid logical inconsistencies.

Fixing comments to better reflect how methods work and some typo fixes

Fix SDWebImageManager transformDownloadedImage

storing data of transformed image instead of downloaded one
(passing nil to storeImage will generate data)

See https://github.com/rs/SDWebImage/pull/326#issuecomment-14791505 for more info

Even if the image is cached, fetch the URL again anyway. When set,
NSURLCache is enabled in the downloader via the new option
SDWebImageDownloaderEnableNSURLCache.

NSURLCache will handle the protocol caching while SDWebImage remains
useful for offline images.

This option helps deal with images changing behind the same request URL,
e.g. Facebook graph api profile pics where the request URL
https://graph.facebook.com/[userid]/picture returns a redirect to the
actual profile image.

If a cached image exists, the completion block is called once with the
cached image and again with the final image.

Detect cancelled parent operation in download operation callback

Optimizing enumeration of files while cleaning the disk cache

Wrong cache policy value.

NSMutableURLRequest accepts NSURLRequestCachePolicy as cachePolicy,
not NSURLCacheStoragePolicy.