ios / yh_sdwebimage · Commits

New Pull Request Checklist

 I have read and understood the CONTRIBUTING guide

 I have read the Documentation

 I have searched for a similar pull request in the project and found none

 I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

 I have added the required tests to prove the fix/feature I am adding

 I have updated the documentation (if necessary)

 I have run the tests and they pass

 I have run the lint and it passes (pod lib lint)

This merge request fixes / reffers to the following issues: ...

Pull Request Description

####Description
There are some problems in this description

Or using marco like SDWebImageCompat avoid deadlocks

#ifndef dispatch_queue_sync_safe
#define dispatch_queue_sync_safe(queue, block)\
if (strcmp(dispatch_queue_get_label(DISPATCH_CURRENT_QUEUE_LABEL), dispatch_queue_get_label(queue)) == 0) {\
block();\
} else {\
dispatch_sync(queue, block);\
}
#endif

…eFromMemoryCacheForKey` instead

…heckIOQueue and add sync version exist API

Currently is used for FLAnimatedImage

…he return type should be instancetype and not a fixed type.

…nc but were async. Left only the 2 async ones

…s sync. Properly marked them as async + added completion. Got rid of the recalculate param. If the `NSData` is provided, use it. Otherwise, recalculate from the `UIImage`

…an ioQueue. Updated the header comments

… cache which I think is misleading. Now `imageFromDiskCacheForKey` only checks the disk cache and the new method `imageFromCacheForKey` checks both caches

…k` to `deleteOldFiles`. No longer expose the sync `clearDisk` and `deleteOldFiles`, just the async ones

…he. Easier to read code

# Conflicts:
#	SDWebImage/MKAnnotationView+WebCache.h
#	SDWebImage/MKAnnotationView+WebCache.m
#	SDWebImage/SDImageCache.h
#	SDWebImage/SDImageCache.m
#	SDWebImage/SDWebImageManager.h
#	SDWebImage/SDWebImageManager.m
#	SDWebImage/UIButton+WebCache.h
#	SDWebImage/UIButton+WebCache.m
#	SDWebImage/UIImageView+HighlightedWebCache.h
#	SDWebImage/UIImageView+HighlightedWebCache.m
#	SDWebImage/UIImageView+WebCache.h
#	SDWebImage/UIImageView+WebCache.m

…25. Decided to make explicit nullable and nonnull and not use NS_ASSUME_NONNULL_BEGIN so everything is clearer when read. Done so in the implementation files as well

…Data (we will need it later for the GIF images).
- had to add an NSData param to `SDWebImageQueryCompletedBlock`, so to make it simpler see this change for users, renamed the block type to `SDCacheQueryCompletedBlock`
- pass the NSData when getting the image from disk cache

- exposing new `- (void)storeImageDataToDisk:(NSData *)imageData
forKey:(NSString *)key` function on SDImageCache
- added unit tests for this new API
- added file extension to kImageTestKey to ensure cache path is valid
for creating NSData

use this:
```shouldDisableMemoryCache``` to toggle memory cache

Custom disk cache path

should say asynchronously in methods ```removeImageForKey...```

allow override diskCachePath