Fix prefetcher test to first clear the disk cache, and manager test to only fulfill the finished one

@@ -110,21 +110,29 @@
 
 
 - (void)test07ThatLoadImageWithSDWebImageRefreshCachedWorks {
 - (void)test07ThatLoadImageWithSDWebImageRefreshCachedWorks {
     XCTestExpectation *expectation = [self expectationWithDescription:@"Image download twice with SDWebImageRefresh failed"];
     XCTestExpectation *expectation = [self expectationWithDescription:@"Image download twice with SDWebImageRefresh failed"];
-    NSURL *originalImageURL = [NSURL URLWithString:kTestJpegURL];
-    [[SDImageCache sharedImageCache] clearDiskOnCompletion:nil];
-    
+    NSURL *originalImageURL = [NSURL URLWithString:@"http://via.placeholder.com/10x10.png"];
+    __block BOOL firstCompletion = NO;
     [[SDWebImageManager sharedManager] loadImageWithURL:originalImageURL options:SDWebImageRefreshCached progress:nil completed:^(UIImage * _Nullable image, NSData * _Nullable data, NSError * _Nullable error, SDImageCacheType cacheType, BOOL finished, NSURL * _Nullable imageURL) {
     [[SDWebImageManager sharedManager] loadImageWithURL:originalImageURL options:SDWebImageRefreshCached progress:nil completed:^(UIImage * _Nullable image, NSData * _Nullable data, NSError * _Nullable error, SDImageCacheType cacheType, BOOL finished, NSURL * _Nullable imageURL) {
         expect(image).toNot.beNil();
         expect(image).toNot.beNil();
         expect(error).to.beNil();
         expect(error).to.beNil();
         // #1993, load image with SDWebImageRefreshCached twice should not fail if the first time success.
         // #1993, load image with SDWebImageRefreshCached twice should not fail if the first time success.
         
         
-        [[SDWebImageManager sharedManager] loadImageWithURL:originalImageURL options:SDWebImageRefreshCached progress:nil completed:^(UIImage * _Nullable image, NSData * _Nullable data, NSError * _Nullable error, SDImageCacheType cacheType, BOOL finished, NSURL * _Nullable imageURL) {
-            expect(image).toNot.beNil();
-            expect(error).to.beNil();
-            [expectation fulfill];
-        }];
+        // Because we call completion before remove the operation from queue, so need a dispatch to avoid get the same operation again. Attention this trap.
+        // One way to solve this is use another `NSURL instance` because we use `NSURL` as key but not `NSString`. However, this is implementation detail and no guarantee in the future.
+        dispatch_async(dispatch_get_main_queue(), ^{
+            NSURL *newImageURL = [NSURL URLWithString:@"http://via.placeholder.com/10x10.png"];
+            [[SDWebImageManager sharedManager] loadImageWithURL:newImageURL options:SDWebImageRefreshCached progress:nil completed:^(UIImage * _Nullable image2, NSData * _Nullable data2, NSError * _Nullable error2, SDImageCacheType cacheType2, BOOL finished2, NSURL * _Nullable imageURL2) {
+                expect(image2).toNot.beNil();
+                expect(error2).to.beNil();
+                if (!firstCompletion) {
+                    firstCompletion = YES;
+                    [expectation fulfill];
+                }
+            }];
+        });
     }];
     }];
-    [self waitForExpectationsWithCommonTimeout];
+    
+    [self waitForExpectationsWithTimeout:kAsyncTestTimeout * 2 handler:nil];
 }
 }
 
 
 @end
 @end

@@ -28,21 +28,23 @@
                            @"http://via.placeholder.com/30x30.jpg",
                            @"http://via.placeholder.com/30x30.jpg",
                            @"http://via.placeholder.com/40x40.jpg"];
                            @"http://via.placeholder.com/40x40.jpg"];
     
     
-    __block int numberOfPrefetched = 0;
+    __block NSUInteger numberOfPrefetched = 0;
     
     
-    [[SDWebImagePrefetcher sharedImagePrefetcher] prefetchURLs:imageURLs progress:^(NSUInteger noOfFinishedUrls, NSUInteger noOfTotalUrls) {
-        numberOfPrefetched += 1;
-        expect(numberOfPrefetched).to.equal(noOfFinishedUrls);
-        expect(noOfFinishedUrls).to.beLessThanOrEqualTo(noOfTotalUrls);
-        expect(noOfTotalUrls).to.equal(imageURLs.count);
-    } completed:^(NSUInteger noOfFinishedUrls, NSUInteger noOfSkippedUrls) {
-        expect(numberOfPrefetched).to.equal(noOfFinishedUrls);
-        expect(noOfFinishedUrls).to.equal(imageURLs.count);
-        expect(noOfSkippedUrls).to.equal(0);
-        [expectation fulfill];
+    [[SDImageCache sharedImageCache] clearDiskOnCompletion:^{
+        [[SDWebImagePrefetcher sharedImagePrefetcher] prefetchURLs:imageURLs progress:^(NSUInteger noOfFinishedUrls, NSUInteger noOfTotalUrls) {
+            numberOfPrefetched += 1;
+            expect(numberOfPrefetched).to.equal(noOfFinishedUrls);
+            expect(noOfFinishedUrls).to.beLessThanOrEqualTo(noOfTotalUrls);
+            expect(noOfTotalUrls).to.equal(imageURLs.count);
+        } completed:^(NSUInteger noOfFinishedUrls, NSUInteger noOfSkippedUrls) {
+            expect(numberOfPrefetched).to.equal(noOfFinishedUrls);
+            expect(noOfFinishedUrls).to.equal(imageURLs.count);
+            expect(noOfSkippedUrls).to.equal(0);
+            [expectation fulfill];
+        }];
     }];
     }];
     
     
-    [self waitForExpectationsWithCommonTimeout];
+    [self waitForExpectationsWithTimeout:kAsyncTestTimeout * 3 handler:nil];
 }
 }
 
 
 - (void)test03PrefetchWithEmptyArrayWillCallTheCompletionWithAllZeros {
 - (void)test03PrefetchWithEmptyArrayWillCallTheCompletionWithAllZeros {