ios / yh_sdwebimage · Commits

Go to a project

Authored by Bogdan Poplauschi
Committed by GitHub
Commit 94cdb773d74967f7ba2feecf0d151012bd965fde 2 parents 2f892f96 4d99ca6c

Merge pull request #1995 from DwayneCoussement/strict-prototype 

CLANG_WARN_STRICT_PROTOTYPES: Yes please!
Inline Side-by-side
Showing 3 changed files with 4 additions and 2 deletions
@@ -3097,6 +3097,7 @@ @@ -3097,6 +3097,7 @@
3097 CLANG_WARN_INFINITE_RECURSION = YES; 3097 CLANG_WARN_INFINITE_RECURSION = YES;
3098 CLANG_WARN_INT_CONVERSION = YES; 3098 CLANG_WARN_INT_CONVERSION = YES;
3099 CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR; 3099 CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
  3100 + CLANG_WARN_STRICT_PROTOTYPES = YES;
3100 CLANG_WARN_SUSPICIOUS_MOVE = YES; 3101 CLANG_WARN_SUSPICIOUS_MOVE = YES;
3101 CLANG_WARN_UNREACHABLE_CODE = NO; 3102 CLANG_WARN_UNREACHABLE_CODE = NO;
3102 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES; 3103 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
@@ -3159,6 +3160,7 @@ @@ -3159,6 +3160,7 @@
3159 CLANG_WARN_INFINITE_RECURSION = YES; 3160 CLANG_WARN_INFINITE_RECURSION = YES;
3160 CLANG_WARN_INT_CONVERSION = YES; 3161 CLANG_WARN_INT_CONVERSION = YES;
3161 CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR; 3162 CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
  3163 + CLANG_WARN_STRICT_PROTOTYPES = YES;
3162 CLANG_WARN_SUSPICIOUS_MOVE = YES; 3164 CLANG_WARN_SUSPICIOUS_MOVE = YES;
3163 CLANG_WARN_UNREACHABLE_CODE = NO; 3165 CLANG_WARN_UNREACHABLE_CODE = NO;
3164 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES; 3166 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
@@ -95,7 +95,7 @@ @@ -95,7 +95,7 @@
95 95
96 FOUNDATION_EXPORT UIImage *SDScaledImageForKey(NSString *key, UIImage *image); 96 FOUNDATION_EXPORT UIImage *SDScaledImageForKey(NSString *key, UIImage *image);
97 97
98 -typedef void(^SDWebImageNoParamsBlock)(); 98 +typedef void(^SDWebImageNoParamsBlock)(void);
99 99
100 FOUNDATION_EXPORT NSString *const SDWebImageErrorDomain; 100 FOUNDATION_EXPORT NSString *const SDWebImageErrorDomain;
101 101
@@ -224,7 +224,7 @@ @@ -224,7 +224,7 @@
224 - (nullable SDWebImageDownloadToken *)addProgressCallback:(SDWebImageDownloaderProgressBlock)progressBlock 224 - (nullable SDWebImageDownloadToken *)addProgressCallback:(SDWebImageDownloaderProgressBlock)progressBlock
225 completedBlock:(SDWebImageDownloaderCompletedBlock)completedBlock 225 completedBlock:(SDWebImageDownloaderCompletedBlock)completedBlock
226 forURL:(nullable NSURL *)url 226 forURL:(nullable NSURL *)url
227 - createCallback:(SDWebImageDownloaderOperation *(^)())createCallback { 227 + createCallback:(SDWebImageDownloaderOperation *(^)(void))createCallback {
228 // The URL will be used as the key to the callbacks dictionary so it cannot be nil. If it is nil immediately call the completed block with no image or data. 228 // The URL will be used as the key to the callbacks dictionary so it cannot be nil. If it is nil immediately call the completed block with no image or data.
229 if (url == nil) { 229 if (url == nil) {
230 if (completedBlock != nil) { 230 if (completedBlock != nil) {