ios / yh_sdwebimage · Commits

Go to a project

Authored by Scott Berrevoets
Commit 3ceb8308eb6b294ea2598611366351b5a99929a1 1 parent 5147ae5c

Enable CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF 

This enables the CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF warning on all
targets. #2225 fixed a number of these, but a new one crept back in so
this fixes that issue as well.
Inline Side-by-side
Showing 2 changed files with 11 additions and 1 deletions
@@ -894,6 +894,7 @@ @@ -894,6 +894,7 @@
894 CLANG_WARN_EMPTY_BODY = YES; 894 CLANG_WARN_EMPTY_BODY = YES;
895 CLANG_WARN_ENUM_CONVERSION = YES; 895 CLANG_WARN_ENUM_CONVERSION = YES;
896 CLANG_WARN_INT_CONVERSION = YES; 896 CLANG_WARN_INT_CONVERSION = YES;
  897 + CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
897 CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR; 898 CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
898 CLANG_WARN_UNREACHABLE_CODE = YES; 899 CLANG_WARN_UNREACHABLE_CODE = YES;
899 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES; 900 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
@@ -932,6 +933,7 @@ @@ -932,6 +933,7 @@
932 CLANG_WARN_EMPTY_BODY = YES; 933 CLANG_WARN_EMPTY_BODY = YES;
933 CLANG_WARN_ENUM_CONVERSION = YES; 934 CLANG_WARN_ENUM_CONVERSION = YES;
934 CLANG_WARN_INT_CONVERSION = YES; 935 CLANG_WARN_INT_CONVERSION = YES;
  936 + CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
935 CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR; 937 CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
936 CLANG_WARN_UNREACHABLE_CODE = YES; 938 CLANG_WARN_UNREACHABLE_CODE = YES;
937 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES; 939 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
@@ -971,6 +973,7 @@ @@ -971,6 +973,7 @@
971 CLANG_WARN_EMPTY_BODY = YES; 973 CLANG_WARN_EMPTY_BODY = YES;
972 CLANG_WARN_ENUM_CONVERSION = YES; 974 CLANG_WARN_ENUM_CONVERSION = YES;
973 CLANG_WARN_INT_CONVERSION = YES; 975 CLANG_WARN_INT_CONVERSION = YES;
  976 + CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
974 CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR; 977 CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
975 CLANG_WARN_UNREACHABLE_CODE = YES; 978 CLANG_WARN_UNREACHABLE_CODE = YES;
976 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES; 979 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
@@ -1009,6 +1012,7 @@ @@ -1009,6 +1012,7 @@
1009 CLANG_WARN_EMPTY_BODY = YES; 1012 CLANG_WARN_EMPTY_BODY = YES;
1010 CLANG_WARN_ENUM_CONVERSION = YES; 1013 CLANG_WARN_ENUM_CONVERSION = YES;
1011 CLANG_WARN_INT_CONVERSION = YES; 1014 CLANG_WARN_INT_CONVERSION = YES;
  1015 + CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
1012 CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR; 1016 CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
1013 CLANG_WARN_UNREACHABLE_CODE = YES; 1017 CLANG_WARN_UNREACHABLE_CODE = YES;
1014 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES; 1018 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
@@ -1049,6 +1053,7 @@ @@ -1049,6 +1053,7 @@
1049 CLANG_WARN_EMPTY_BODY = YES; 1053 CLANG_WARN_EMPTY_BODY = YES;
1050 CLANG_WARN_ENUM_CONVERSION = YES; 1054 CLANG_WARN_ENUM_CONVERSION = YES;
1051 CLANG_WARN_INT_CONVERSION = YES; 1055 CLANG_WARN_INT_CONVERSION = YES;
  1056 + CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
1052 CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR; 1057 CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
1053 CLANG_WARN_UNREACHABLE_CODE = YES; 1058 CLANG_WARN_UNREACHABLE_CODE = YES;
1054 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES; 1059 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
@@ -1087,6 +1092,7 @@ @@ -1087,6 +1092,7 @@
1087 CLANG_WARN_EMPTY_BODY = YES; 1092 CLANG_WARN_EMPTY_BODY = YES;
1088 CLANG_WARN_ENUM_CONVERSION = YES; 1093 CLANG_WARN_ENUM_CONVERSION = YES;
1089 CLANG_WARN_INT_CONVERSION = YES; 1094 CLANG_WARN_INT_CONVERSION = YES;
  1095 + CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
1090 CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR; 1096 CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
1091 CLANG_WARN_UNREACHABLE_CODE = YES; 1097 CLANG_WARN_UNREACHABLE_CODE = YES;
1092 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES; 1098 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
@@ -1127,6 +1133,7 @@ @@ -1127,6 +1133,7 @@
1127 CLANG_WARN_EMPTY_BODY = YES; 1133 CLANG_WARN_EMPTY_BODY = YES;
1128 CLANG_WARN_ENUM_CONVERSION = YES; 1134 CLANG_WARN_ENUM_CONVERSION = YES;
1129 CLANG_WARN_INT_CONVERSION = YES; 1135 CLANG_WARN_INT_CONVERSION = YES;
  1136 + CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
1130 CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR; 1137 CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
1131 CLANG_WARN_UNREACHABLE_CODE = YES; 1138 CLANG_WARN_UNREACHABLE_CODE = YES;
1132 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES; 1139 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
@@ -1165,6 +1172,7 @@ @@ -1165,6 +1172,7 @@
1165 CLANG_WARN_EMPTY_BODY = YES; 1172 CLANG_WARN_EMPTY_BODY = YES;
1166 CLANG_WARN_ENUM_CONVERSION = YES; 1173 CLANG_WARN_ENUM_CONVERSION = YES;
1167 CLANG_WARN_INT_CONVERSION = YES; 1174 CLANG_WARN_INT_CONVERSION = YES;
  1175 + CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
1168 CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR; 1176 CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
1169 CLANG_WARN_UNREACHABLE_CODE = YES; 1177 CLANG_WARN_UNREACHABLE_CODE = YES;
1170 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES; 1178 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
@@ -1276,6 +1284,7 @@ @@ -1276,6 +1284,7 @@
1276 isa = XCBuildConfiguration; 1284 isa = XCBuildConfiguration;
1277 buildSettings = { 1285 buildSettings = {
1278 ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon; 1286 ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
  1287 + CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
1279 FRAMEWORK_SEARCH_PATHS = ( 1288 FRAMEWORK_SEARCH_PATHS = (
1280 "$(inherited)", 1289 "$(inherited)",
1281 "\"$(SRCROOT)\"", 1290 "\"$(SRCROOT)\"",
@@ -1303,6 +1312,7 @@ @@ -1303,6 +1312,7 @@
1303 isa = XCBuildConfiguration; 1312 isa = XCBuildConfiguration;
1304 buildSettings = { 1313 buildSettings = {
1305 ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon; 1314 ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
  1315 + CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
1306 FRAMEWORK_SEARCH_PATHS = ( 1316 FRAMEWORK_SEARCH_PATHS = (
1307 "$(inherited)", 1317 "$(inherited)",
1308 "\"$(SRCROOT)\"", 1318 "\"$(SRCROOT)\"",
@@ -175,7 +175,7 @@ FOUNDATION_STATIC_INLINE NSUInteger SDCacheCostForImage(UIImage *image) { @@ -175,7 +175,7 @@ FOUNDATION_STATIC_INLINE NSUInteger SDCacheCostForImage(UIImage *image) {
175 } 175 }
176 176
177 dispatch_sync(_ioQueue, ^{ 177 dispatch_sync(_ioQueue, ^{
178 - _fileManager = [NSFileManager new]; 178 + self.fileManager = [NSFileManager new];
179 }); 179 });
180 180
181 #if SD_UIKIT 181 #if SD_UIKIT