Do not init an activity indictor if image isn't downloading in demo app (good practice)

Olivier Poitrey
Commit 1ec36c7c9902c793d5608f2595e7aaa0c8e6889f 1 parent a7af2a19
Showing 1 changed file with 12 additions and 5 deletions
Examples/SDWebImage Demo/DetailViewController.m
--- a/Examples/SDWebImage Demo/DetailViewController.m
View file @1ec36c7
+++ b/Examples/SDWebImage Demo/DetailViewController.m
View file @1ec36c7
@@ -33,13 +33,20 @@
 {
     if (self.imageURL)
     {
-         UIActivityIndicatorView *activityIndicator;
-         [self.imageView addSubview:activityIndicator = [UIActivityIndicatorView.alloc initWithActivityIndicatorStyle:UIActivityIndicatorViewStyleGray]];
-         activityIndicator.center = self.imageView.center;
-         [activityIndicator startAnimating];
-         [self.imageView setImageWithURL:self.imageURL placeholderImage:nil options:SDWebImageProgressiveDownload completed:^(UIImage *image, NSError *error, SDImageCacheType cacheType)
+         __block UIActivityIndicatorView *activityIndicator;
+         [self.imageView setImageWithURL:self.imageURL placeholderImage:nil options:SDWebImageProgressiveDownload progress:^(NSUInteger receivedSize, long long expectedSize)
+         {
+             if (!activityIndicator)
+             {
+                 [self.imageView addSubview:activityIndicator = [UIActivityIndicatorView.alloc initWithActivityIndicatorStyle:UIActivityIndicatorViewStyleGray]];
+                 activityIndicator.center = self.imageView.center;
+                 [activityIndicator startAnimating];
+             }
+         }
+         completed:^(UIImage *image, NSError *error, SDImageCacheType cacheType)
         {
             [activityIndicator removeFromSuperview];
+             activityIndicator = nil;
         }];
     }
 }