ios / yh_sdwebimage · Commits

Go to a project

Authored by Bogdan Poplauschi
Committed by Bogdan Poplauschi
Commit 0df12218b7b9a4c633d057158272a33df388ff58 1 parent 2064f28d

Enabled CLANG_ANALYZER_NONNULL per http://indiestack.com/2016/06/nullable-edge-c… 

…ases/. Small fix for a case where trying to get from a set using a nil key
Inline Side-by-side
Showing 2 changed files with 6 additions and 2 deletions
... ... @@ -1350,6 +1350,7 @@
isa = XCBuildConfiguration;
buildSettings = {
ALWAYS_SEARCH_USER_PATHS = NO;
CLANG_ANALYZER_NONNULL = YES;
CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
CLANG_CXX_LIBRARY = "libc++";
CLANG_ENABLE_MODULES = YES;
... ... @@ -1410,6 +1411,7 @@
isa = XCBuildConfiguration;
buildSettings = {
ALWAYS_SEARCH_USER_PATHS = NO;
CLANG_ANALYZER_NONNULL = YES;
CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
CLANG_CXX_LIBRARY = "libc++";
CLANG_ENABLE_MODULES = YES;
... ...
... ... @@ -140,8 +140,10 @@
__weak SDWebImageCombinedOperation *weakOperation = operation;
BOOL isFailedUrl = NO;
@synchronized (self.failedURLs) {
isFailedUrl = [self.failedURLs containsObject:url];
if (url) {
@synchronized (self.failedURLs) {
isFailedUrl = [self.failedURLs containsObject:url];
}
}
if (url.absoluteString.length == 0 || (!(options & SDWebImageRetryFailed) && isFailedUrl)) {
... ...