• This project
    • Loading...
  • Sign in

fe / yohobuy-node · Merge Requests

Go to a project

GitLab

  • Go to group
  • Project
  • Activity
  • Files
  • Commits
  • Pipelines 0
  • Builds 0
  • Graphs
  • Milestones
  • Issues 1
  • Merge Requests 0
  • Members
  • Labels
  • Wiki
  • Forks
  • Network
  • Create a new issue
Merged
Merge Request !8 opened 2016-12-02 05:42:38 UTC bygexuhui@gexuhui

Feature/getbanner action

有货 头部 banner广告和 头部个人用户下拉列表

Edited 2016-12-13 13:22:11 UTC
Request to merge feature/getbannerAction into release/5.3
×

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b feature/getbannerAction origin/feature/getbannerAction

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git checkout release/5.3
git merge --no-ff feature/getbannerAction

Step 4. Push the result of the merge to GitLab

git push origin release/5.3

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines

Merged by 周少峰 2016-12-13 13:22:06 UTC

The changes were merged into release/5.3. The source branch has been removed.

  • Discussion 4
  • Commits 11
  • Changes 5
  • gexuhui
    @gexuhui 2016-12-02 05:54:46 UTC

    Added 1 commit:

    • 4a608e34 - 有货头部 个人中心下拉列表
  • Avatar
    杨延青
    @yangyanqing started a discussion on an outdated diff 2016-12-02 05:59:45 UTC
    Toggle discussion
    apps/common/controllers/getBanner.js 0 → 100644
    if (!width || !height) {
    width = 2600;
    height = 60;
    }
    }
    banner.src = helpers.image(banner.src, width, height, 2);
    banner.url = banner.url;
    res.jsonp({
    code: 200,
    data: banner
    });
    }
    }
    });
    • 杨延青
      @yangyanqing commented 2016-12-02 05:59:45 UTC
      Master

      加上异常捕获

      Edited 2016-12-02 06:00:03 UTC
  • Avatar
    杨延青
    @yangyanqing started a discussion on an outdated diff 2016-12-02 06:01:51 UTC
    Toggle discussion
    apps/common/controllers/passport.js 0 → 100644
    return null;
    });
    let userNum = yield passportModel.getUserInfoNum(uid).then(ret => {
    if (ret && ret.code === 200) {
    return ret.data;
    }
    });
    // 个人信息调用失败返回
    if (profile) {
    userInfo.result = 1;
    // 个人资料
    userInfo.profileName = _.get(profile, 'profile_name', '');
    • 杨延青
      @yangyanqing commented 2016-12-02 06:01:51 UTC
      Master

      使用Object.assign()

  • Avatar
    杨延青
    @yangyanqing started a discussion on the diff 2016-12-02 06:07:47 UTC
    Toggle discussion
    apps/common/controllers/getBanner.js 0 → 100644
    * @author: gxh<xuhui.ge@yoho.cn>
    * @date: 2016/11/30
    */
    'use strict';
    const getBannerModel = require('../models/getBanner');
    const helpers = global.yoho.helpers;
    const index = (req, res) => {
    let contentCode = req.query.content_code || '';
    let width = req.query.width || '';
    let height = req.query.height || '';
    getBannerModel.getResource(contentCode).then(data => {
    • 杨延青
      @yangyanqing commented 2016-12-02 06:07:47 UTC
      Master

      then数据处理方法有可能没有返回,建议if else 处理数据 ,最后返回处理完数据的json

  • Avatar
    杨延青
    @yangyanqing started a discussion on an outdated diff 2016-12-02 06:11:04 UTC
    Toggle discussion
    apps/common/controllers/passport.js 0 → 100644
    }
    // 待处理订单
    userInfo.order = _.get(userNum, 'wait_pay_num + wait_cargo_num + send_cargo_num', 0);
    // 我的收藏
    userInfo.favorite = _.get(userNum, 'brand_favorite_total', 0);
    // 我的优惠券
    userInfo.coupon = _.get(userNum, 'coupon_num', 0);
    // 我的有货币
    userInfo.coin = _.get(userNum, 'yoho_coin_num', 0);
    // 我的退换货
    userInfo.coin = _.get(userNum, 'refund_exchange_num', 0);
    • 杨延青
      @yangyanqing commented 2016-12-02 06:11:04 UTC
      Master

      退换货还是coin???

  • gexuhui
    @gexuhui 2016-12-02 06:46:52 UTC

    Added 1 commit:

    • 3142267e - 有货头部 个人中心下拉列表
  • 周少峰
    @zhoushaofeng 2016-12-13 13:22:06 UTC
    Master

    Status changed to merged

  • 周少峰
    @zhoushaofeng 2016-12-13 13:22:06 UTC
    Master

    mentioned in commit 9f6e3ae5

  • Please register or login to post a comment
8 of 450
Prev Next
周少峰
Assignee
周少峰 @zhoushaofeng
Assign to
None
Milestone
None
Assign milestone
0
Labels
None
Assign labels
  • View labels
1
1 participant
Reference: fe/yohobuy-node!8
×

Revert this merge request

Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Cancel
A new branch will be created in your fork and a new merge request will be started.