添加对app中client_secret的校验

Code Review By Rock Zhang

@@ -25,12 +25,7 @@ class CouponController extends AbstractAction
         $uid = $this->getUid(true);
         $uid = $this->getUid(true);
         $app = $this->get('app', array());
         $app = $this->get('app', array());
 
 
-        // APP时用参数中的ID
-        if (!empty($app)) {
-            $uid = isset($app['uid']) ? $app['uid'] : 0;
-        }
-
-        $result = CouponModel::couponSend($uid, $token);
+        $result = CouponModel::couponSend($uid, $token, $app);
 
 
         $this->helpJsonCallbackResult($callback, $result['code'], $result['message'], $result['data']);
         $this->helpJsonCallbackResult($callback, $result['code'], $result['message'], $result['data']);
     }
     }

@@ -2,6 +2,8 @@
 
 
 namespace Coupon;
 namespace Coupon;
 
 
+use Api\Sign;
+use Api\Yohobuy;
 use LibModels\Wap\Cuxiao\ActivityData;
 use LibModels\Wap\Cuxiao\ActivityData;
 use Plugin\Helpers;
 use Plugin\Helpers;
 
 
@@ -21,13 +23,19 @@ class CouponModel
      *
      *
      * @param int $uid 用户ID
      * @param int $uid 用户ID
      * @param string $token 发券标记
      * @param string $token 发券标记
+     * @param array $app url中传递的app有关的参数
      * @return mixed
      * @return mixed
      */
      */
-    public static function couponSend($uid, $token)
+    public static function couponSend($uid, $token, $app)
     {
     {
         $result = array('code' => 403, 'message' => '参数错误', 'data' => '');
         $result = array('code' => 403, 'message' => '参数错误', 'data' => '');
 
 
         do {
         do {
+            // APP时用参数中的ID
+            if (self::checkApp($app)) {
+                $uid = isset($app['uid']) ? $app['uid'] : 0;
+            }
+
             // 用户ID或者发券标记为空时
             // 用户ID或者发券标记为空时
             if (empty($uid) || empty($token)) {
             if (empty($uid) || empty($token)) {
                 break;
                 break;
@@ -36,6 +44,8 @@ class CouponModel
             $couponResult = ActivityData::couponSend($uid, $token);
             $couponResult = ActivityData::couponSend($uid, $token);
             // 接口返回错误时
             // 接口返回错误时
             if (empty($couponResult)) {
             if (empty($couponResult)) {
+                $result['code'] = 404;
+                $result['message'] = '出错啦~';
                 break;
                 break;
             }
             }
 
 
@@ -45,4 +55,26 @@ class CouponModel
         return $result;
         return $result;
     }
     }
 
 
+    /**
+     * 校验是否为app
+     *
+     * @param array $app url中传递的app有关的参数
+     * @return bool
+     */
+    private static function checkApp($app)
+    {
+        $isApp = false;
+
+        // APP时用参数中的ID
+        if (!empty($app) && isset($app['client_secret'])) {
+            $params = $app;
+            unset($params['client_secret']);
+            $params['private_key'] = Yohobuy::$privateKeyList[$params['client_type']];
+
+            $isApp = ($app['client_secret'] === Sign::getSign($params));
+        }
+
+        return $isApp;
+    }
+
 }
 }